Skip to content

feat: relax error message for number-typed coder parameters #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 19, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Feb 16, 2024

Related: coder/coder#12192

Right now, only string-typed parameters can use custom messages. This PR relaxes strict validation rules to support custom errors for number-typed coder parameters.

@mtojek mtojek self-assigned this Feb 16, 2024
@mtojek mtojek changed the title feat: support custom error message for number-typed coder parameters feat: relax error message for number-typed coder parameters Feb 19, 2024
@mtojek mtojek requested a review from johnstcn February 19, 2024 13:52
@mtojek mtojek marked this pull request as ready for review February 19, 2024 13:52
@mtojek mtojek requested a review from johnstcn February 19, 2024 15:22
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Up to you if you want to mention {value}, {min}, and {max} in the doc.

@mtojek mtojek merged commit f5dc37c into main Feb 19, 2024
@mtojek mtojek deleted the 12192-number-error branch February 19, 2024 15:33
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants